Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor foreground color #97

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

rkfg
Copy link
Contributor

@rkfg rkfg commented Oct 12, 2022

The new gocui black color is gray unless dimmed. It's better to dim it for readability.

@rkfg rkfg mentioned this pull request Oct 12, 2022
@edouardparis
Copy link
Owner

Thanks !

@edouardparis edouardparis merged commit 0bb5922 into edouardparis:master Oct 14, 2022
@hieblmi
Copy link
Contributor

hieblmi commented Oct 18, 2022

Thanks for the PR @rkfg. For some reason the contrast still isn't right for me.
image

Is there a config flag I have to set?

@rkfg rkfg deleted the color-fix branch October 18, 2022 19:48
@rkfg
Copy link
Contributor Author

rkfg commented Oct 18, 2022

That's weird. No, there's no config flag, it should set the foreground color to pure black. What's your normal background color there in other rows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants