Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: admin vs. regular users, filesystem permission crash at startup (EDRLab.ThoriumReader folder user access control?) #1514

Closed
preevi-singh opened this issue Jun 17, 2021 · 35 comments
Closed

Windows: admin vs. regular users, filesystem permission crash at startup (EDRLab.ThoriumReader folder user access control?) #1514

preevi-singh opened this issue Jun 17, 2021 · 35 comments

Comments

@preevi-singh
Copy link

thorium is not compatible with windows 21H1 version. and I am using latest version 1.7.00 it always shows java script error although I have downloaded it from microsoft store. I would be glad to see hindi language included in the further update.
@llemeurfr
Copy link
Contributor

Hi @preevi-singh, I'm surprised by the windows 21H1 issue you're raising, we'll check on our side. Can you please detail what happens, and did you install the June Patch Tuesday? (the initial release was buggy I heard).

Re. the Hindi language, translations are community based. Volunteers maintain the translation of a json document in each supported language. We'll first check if there could be technical issues with Hindi. If being in charge of the Hindi translation would be ok for you, we'll then be able to organize that with you.

@llemeurfr llemeurfr changed the title reporting a problem v1.7 not working on Windows 21H1? Jun 17, 2021
@preevi-singh
Copy link
Author

preevi-singh commented Jun 18, 2021 via email

@preevi-singh
Copy link
Author

thorium is not compatible with windows 21H1 version. and I am using latest version 1.7.00 it always shows java script error although I have downloaded it from microsoft store. I would be glad to see hindi language included in the further update.

¦
•*>
• /C .
"¦1: *

' X

© Error

  • Application init Error

main rootSaga: OpenError: IO error: C:\Users\PREEVI
SINGH\AppData\Roaming\EDRLab.ThoriumReader\db\lcp-secret/MANIFEST-000020: The system cannot find the file specified.

zX T CODE

tro Pane

@preevi-singh
Copy link
Author

code was 01

@llemeurfr llemeurfr reopened this Jun 18, 2021
@llemeurfr
Copy link
Contributor

Hi Preevi, did you close this issue by mistake? your last comment is cryptic.

@danielweck
Copy link
Member

Hello, I am building Thorium on a recently-updated Windows machine. I will report back with my findings once I have finished running tests with a conventional app installer, as well as with a Windows Store deployment.

@danielweck
Copy link
Member

I am unable to reproduce the reported bug with Windows 10 20H2 and Thorium 1.7.0 (I will publish 1.7.1 soon to the Windows Store ... work in progress)

@danielweck
Copy link
Member

I am installing Windows 10 Pro update 21H1 ...

@danielweck
Copy link
Member

I am now on Windows 10 Pro 21H1, but I am unable to reproduce the reported bug. Thorium 1.7 installed from the Windows Store launches fine. The app settings are stored in C:\Users\daniel\AppData\Roaming\EDRLab.ThoriumReader\ (not in the special Packages folder which is sometimes used by Windows)

@danielweck
Copy link
Member

I uninstalled Thorium 1.7, re-installed the app via the Windows Store, and I tried running the app with both previous / existing settings located in C:\Users\daniel\AppData\Roaming\EDRLab.ThoriumReader\ and fresh new settings in C:\Users\daniel\AppData\Local\Packages\EDRLab.ThoriumReader_xxxx\LocalCache\Roaming\EDRLab.ThoriumReader\.

=> No crash, everything seems to work fine.

@preevi-singh
Copy link
Author

preevi-singh commented Jun 18, 2021 via email

@danielweck
Copy link
Member

Suggestion: rename your folder C:\Users\PREEVISINGH\AppData\Roaming\EDRLab.ThoriumReader (for example, add a character at the end of the folder name), and launch Thorium again.

@llemeurfr
Copy link
Contributor

Looking a the path given in the error, C:\Users\PREEVI SINGH\AppData\Roaming\EDRLab.ThoriumReader\db\lcp-secret/MANIFEST-000020, I do not understand your suggestion Daniel.

@danielweck
Copy link
Member

This is a process of elimination: when Thorium starts "from scratch", the Electron framework will generate an app-specific folder in either C:\Users\XX\AppData\Roaming\EDRLab.ThoriumReader\ or C:\Users\XX\AppData\Local\Packages\EDRLab.ThoriumReader_xxxx\LocalCache\Roaming\EDRLab.ThoriumReader\.

@llemeurfr
Copy link
Contributor

ah ok you mean rename the folder to something else ...

@preevi-singh
Copy link
Author

preevi-singh commented Jun 18, 2021 via email

@llemeurfr
Copy link
Contributor

To improve the app we need your assistance. Could you please rename temporarily this folder so that we can check what happens?

@preevi-singh
Copy link
Author

preevi-singh commented Jun 18, 2021 via email

@llemeurfr
Copy link
Contributor

the detail of the answer depends on your technical expertise. Are you a developer, and advanced windows user or casual windows user?

@preevi-singh
Copy link
Author

preevi-singh commented Jun 18, 2021 via email

@llemeurfr
Copy link
Contributor

If you are a casual Windows user:

  • close Thorium
  • open a terminal
  • type "ren C:\Users\PREEVI SINGH\AppData\Roaming\EDRLab.ThoriumReader EDRLab.ThoriumReader1"
  • check if the command is accepted
  • launch Thorium and advise. The bookshelf should be empty but no ebook is lost.

@danielweck
Copy link
Member

improve the app so that a normal person can install it easily in any folder where he/she wants to and can use it easily.

Hello, you can install Thorium from the Windows Store or from a regular installer (Thorium.Setup.1.7.1.exe):
https://github.com/edrlab/thorium-reader/releases/tag/v1.7.1

Windows OS traditionally uses the "C:/Program Files" folder, but for some apps the installation folder is C:\Users\XX\AppData\Roaming\Programs\EDRLab.ThoriumReader\ (if I remember correctly)

@danielweck
Copy link
Member

type "ren C:\Users\PREEVI SINGH\AppData\Roaming\EDRLab.ThoriumReader EDRLab.ThoriumReader1"

This is unlikely to work because of the space character in PREEVI SINGH

@danielweck
Copy link
Member

How to do so?

You can use the file explorer to go to your C:\Users\PREEVISINGH\AppData\Roaming\EDRLab.ThoriumReader folder, but note that the AppData subfolder is in fact hidden, so you may have to make sure that file explorer displays hidden files.

@danielweck
Copy link
Member

similar error message in this project:
storj-archived/storjshare-gui#675

@danielweck
Copy link
Member

another similar error message:
Level/levelup#222

@llemeurfr
Copy link
Contributor

Similar warning from another user, this time with a screenshot:

image

Version 1.7.1 downloaded directly from the repository.

"I click download and am able to start installing. Then when the installation is supposed to be finished, I receive the following message ..."

@llemeurfr llemeurfr reopened this Jul 23, 2021
@danielweck
Copy link
Member

So, it looks like a LevelDB / LevelDown error, judging by the filepath (the keyword "MANIFEST-xxx" is a clue too).

@danielweck
Copy link
Member

Filesystem permission problem?
Concurrent process IO access?

@llemeurfr
Copy link
Contributor

Some details:

  • is it the same message you've seen initially (what you called "notification that a virus was stopped from the download") ?

I use McAfee virus protection, and after I receive the screenshot notification, I receive another notification from McAfee indicating that a virus was stopped from downloading.

  • did you use a previous version of Thorium before, and which one?

Yes I did! I used the last version of Thorium that was available in February 2021 (not sure the version number). I had no issues with this until a Windows update occurred and then I was not able to open Thorium at all. That was when I tried to download the latest version, 1.7.1.

  • did you update your Windows system to the latest version lately (named 21H1 in the litterature)? it seems that the issue could be tied to an update of Windows (but with the new version we still cannot reproduce).

Yes, an automatic update from Windows happened last week which is when my Thorium stopped working.

  • if we recommend that you delete the database of ebooks which is handled by Thorium, will it be an issue for you?

I'm not sure what this means. Currently, I have completely deleted and uninstalled the last version of Thorium that I had, hoping it would help the new installation.

@llemeurfr llemeurfr added this to To do in 1.7.2 via automation Aug 11, 2021
@danielweck danielweck removed this from To do in 1.7.2 Aug 28, 2021
@danielweck
Copy link
Member

Closing due to lack of feedback / activity. Feel free to reopen if the bug re-occurs! Thank you :)

@danielweck
Copy link
Member

The problem still occurs, it seems:
image001

@danielweck
Copy link
Member

danielweck commented Mar 28, 2022 •
edited

This more recent bug report (see screenshot in previous message) seems to be correlated with filesystem permissions, as things work fine in administrator mode. Looks like the EDRLab.ThoriumReader folder gets conflicting read/write permissions on Windows, depending on user access control?

Previously-reported error is very similar:

image

@danielweck danielweck reopened this Mar 28, 2022
@danielweck danielweck changed the title v1.7 not working on Windows 21H1? Windows: admin vs. regular users, filesystem permission crash at startup (EDRLab.ThoriumReader folder user access control?) Mar 28, 2022
@danielweck
Copy link
Member

danielweck commented Mar 28, 2022 •
edited

In the screenshots below I highlighted the text that Thorium programmatically inserts (all other text is generated by Windows OS or some underlying software library outside of our control, text which we obtain from the captured error / exception message):

Note the broken accented characters, yet Thorium pass Unicode string to https://www.electronjs.org/docs/latest/api/dialog#dialogshowerrorboxtitle-content

image001
126803540-db478847-9a45-4aa5-9f05-cc8eea9e0f1e

@danielweck
Copy link
Member

Closing due to lack of activity, issue not actionable as unidentified problem. Clearly if the problem continues to be reported we will record the feedback but this is impossible to fix without a reproducible pattern, and this may in fact not be fixable at all in Thorium (Electron + Windows issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielweck @llemeurfr @preevi-singh