operator *= and /= have to pass rhs by value because a const ref that…

… aliases one of the elements of the vector/matrix causes failure (the referenced value changes when that element of vector/matrix is modified)
edrosten · Sep 5, 2012 · eed7ed6 · eed7ed6
1 parent b8bd385
commit eed7ed6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/internal/matrix.hh b/internal/matrix.hh
@@ -200,7 +200,7 @@ public:
 	///@name operations on the matrix
 	///@{
 
-	Matrix& operator*=(const Precision& rhs)
+	Matrix& operator*=(const Precision rhs)
 	{
 		  for(int r=0; r < num_rows(); r++)
 			  for(int c=0; c < num_cols(); c++)
@@ -209,7 +209,7 @@ public:
 		  return *this;
 	}
 
-	Matrix& operator/=(const Precision& rhs)
+	Matrix& operator/=(const Precision rhs)
 	{
 		  for(int r=0; r < num_rows(); r++)
 			  for(int c=0; c < num_cols(); c++)

diff --git a/internal/vector.hh b/internal/vector.hh
@@ -281,14 +281,14 @@ public:
 	/// @{
 
 	/// divide this vector by a constant
-	Vector& operator/=(const Precision& rhs) {
+	Vector& operator/=(const Precision rhs) {
 		for(int i=0; i<size(); i++)
 			(*this)[i]/=rhs;
 		return *this;
 	}
 
 	/// multiply this vector by a constant
-	Vector& operator*=(const Precision& rhs) {
+	Vector& operator*=(const Precision rhs) {
 		for(int i=0; i<size(); i++)
 			(*this)[i]*=rhs;
 		return *this;