Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception with IsUsingLatestVersion #42

Open
grounch opened this issue May 24, 2022 · 20 comments
Open

Exception with IsUsingLatestVersion #42

grounch opened this issue May 24, 2022 · 20 comments

Comments

@grounch
Copy link

grounch commented May 24, 2022

If this issue is for a new feature, please skip the "Bug" section and fill out the "Feature Request" section at the bottom.

Bug

Plugin Version: 2.1.0
Platform (e.g., Android v21): Multiple Android phone brands in multiple os version (10,11,12...)

Expected behavior

IsUsingLatestVersion working fine

Actual behavior

getting lot of error logged with such stacktrace:

Error comparing current app version number with latest. Version name=22.2.2.88285 and lastest version= .

at Plugin.LatestVersion.LatestVersionImplementation.IsUsingLatestVersion () [0x000e8] in :0

Steps to reproduce the issue

Happens since last update of the app version which happened today.
Error happens when having the previous app version installed (22.2.1) and updating to new one (22.2.2).
Hard to reproduce as need to have previous version from the store installed before doing the update.

Is there some cache that's not wiped out at update or what else could trigger this exception?

https://play.google.com/store/apps/details?id={_packageName}&hl=en returns the latest version number (with my package name)

@AshaMandaliyaGohil
Copy link

AshaMandaliyaGohil commented May 27, 2022

I am also getting the same issue in Android app. My app checks if user is using the latest version or not. If not a latest version it won't allow login and user need to install the latest version first in order to login into the app.

image

This is a blocker for my app right now. @edsnider : Would you please quickly look into this issue?

EDIT: FYI - Google has completely changed the Play Store UI. This may be the reason this Brocken?

Thank you.

@larsfsonderskov
Copy link

larsfsonderskov commented May 27, 2022

I have same issue here. I use the version checker to deside between connecting to prod or dev/test. Due to this error our users are current unable to login at all :(

The problems started appearing sporatically over the last week or so, but this morning it is consistently appearing.

Hope you can deploy a quick fix without upgrading the Nuget!

Edit: Issue is only related to Android, so assume something changed on Google Play

@Pro-4-Soft
Copy link

we've got the same thing

@NelBarnatia
Copy link

I have the same issue. After looking at the repo code there was a regex code that finding some certain div for the version from the play store. But after google play store update the web site it seems that the div for version number has been remove so that's why the latest version is always empty string.

I suggest you guys create the versioning on your own server that's best we can do right now.

image

@NelBarnatia
Copy link

I am also getting the same issue in Android app. My app checks if user is using the latest version or not. If not a latest version it won't allow login and user need to install the latest version first in order to login into the app.

image

This is a blocker for my app right now. @edsnider : Would you please quickly look into this issue?

EDIT: FYI - Google has completely changed the Play Store UI. This may be the reason this Brocken?

Thank you.

Indeed the play store UI update is the culprit they removed the div that this plug in has on its regex expression.

@grounch
Copy link
Author

grounch commented May 30, 2022

Indeed the data we get as response for https://play.google.com/store/apps/details?id=(package_name)&hl=en is completely different from before.
The version number is still returned, but it's lost in the middle of other data and have no title as was before "current version".
Not sure i know how to dig in the response to retrieve this version number.

@issamben7
Copy link

I was able to make it work for me by changing the regex expression in

var versionMatch = Regex.Match(content, "<div[^>]*>Current Version</div><span[^>]*><div[^>]*><span[^>]*>(.*?)<").Groups[1];
to this ",\\[\\[\\[\"(\\d\\.\\d\\.\\d\\.\\d)\"\\]\\]".

@larsfsonderskov
Copy link

larsfsonderskov commented Jun 7, 2022 via email

@grounch
Copy link
Author

grounch commented Jun 9, 2022

@edsnider are support and maintenance ended on this plugin?

@gsgou
Copy link

gsgou commented Jun 11, 2022

@issamben7 did you tested your regex in production environment already so i can use it over a fork on my next release?

@wtheronjones
Copy link

let me know when this one is resolved

@issamben7
Copy link

@gsgou I implemented it on my app and tested it, but I never deployed it into production since we decided to store the version on a dedicated server to avoid problems in the future.

@olivertech
Copy link

Anyone has any notice about this bug ? Is it resolved ? Thanks.

@grounch
Copy link
Author

grounch commented Jul 7, 2022

The new beta version seems to have solve the issue on Android. Thanks to those who worked on it

@wtheronjones
Copy link

is the nuget package updated yet?

@wtheronjones
Copy link

when will the nuget package be updated?

@Jerome-Liger
Copy link
Contributor

You can have the nuget with these modifications in the beta version here : https://www.nuget.org/packages/Xam.Plugin.LatestVersion/2.1.1-beta.107

With VS NPM, just check "Include Prerelease" and update to 2.1.1-beta.107

@Hjord
Copy link

Hjord commented Sep 13, 2022

I still have the problem with version 2.1.1-beta.107, though the error says lastest version=' instead of lastest version= .

@vchelaru
Copy link

Confirmed, I see the same problem Error comparing current app version number with latest. Version name=5.0.0 and lastest version= using the beta, and it's not fixed in the normal (non-beta) release either.

@gsgou
Copy link

gsgou commented Sep 22, 2022

@vchelaru there is a PR but is not getting merged 3w now. You can follow up the conversation and maybe leave a comment:
#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests