Add screenshots of wikipedia diffs to posts #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure how to test that it's working, though.
…creenshot also upgrade the twit package because there were errors when uploading image metadata to twitter that have been fixed in newer versions.
|
Any word on merging this @edsu? |
|
I'm really sorry for the delay. I've been swamped at work, and haven't had the time to invest in learning Kubernetes so I can use the latest Node in Wikimedia Labs #154. But there's no reason for me to delay merging this right now. I can always deploy it later. Thanks again for all your work putting this together, it's a very important addition to provide more transparency about the edits that are being announced. |
|
Ah, thanks, and good luck with the Kubernetes switchover! Additionally, thank you for being so responsive and clear in your communication! It's been very pleasurable. I'm looking forward to seeing the screenshots in action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's nice to get a preview of the diff in your feed instead of just a notice that something has changed. See #151.