feat: mfe multitenant config #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoa
requested review from
Alec4r,
danielsgz,
Henrrypg,
jignaciopm,
JuanDavidBuitrago,
MaferMazu,
01001110J and
Squirrel18
dcoa
force-pushed
the
dcoa/mfe-multitenant-config
branch
from
fda16a6
to
836a3ba
Compare
Codecov ReportBase: 81.51% // Head: 81.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 81.51% 81.53% +0.01%
==========================================
Files 38 38
Lines 925 926 +1
Branches 169 169
==========================================
+ Hits 754 755 +1
Misses 159 159
Partials 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
01001110J
reviewed
Dec 15, 2022
dcoa
force-pushed
the
dcoa/mfe-multitenant-config
branch
from
836a3ba
to
40afff8
Compare
|
@dcoa, do you have how to test this and the expected result, or is it only a code review? 👀 |
Only code review |
|
Looks good to me @dcoa ✨ |
MaferMazu
approved these changes
Dec 21, 2022
01001110J
approved these changes
Dec 22, 2022
01001110J
approved these changes
Dec 22, 2022
Henrrypg
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a second query param to identify the tenant and the API could send their specific configurations.
This implementation is based on version 1 explained here .
Note
This PR is only for review coding and can't be marge.
Jirs card DS-129: https://edunext.atlassian.net/browse/DS-129