feat: add nutmeg release support #18
Conversation
| @@ -51,9 +51,8 @@ WORKDIR /var/tmp | |||
| RUN mkdir -p common/lib/ | |||
|
|
|||
| COPY --from={{ DOCKER_IMAGE_OPENEDX }} /openedx/edx-platform/common/lib/sandbox-packages common/lib/sandbox-packages | |||
| COPY --from={{ DOCKER_IMAGE_OPENEDX }} /openedx/edx-platform/common/lib/symmath common/lib/symmath | |||
There was a problem hiding this comment.
Do we not need symmath anymore? or is it included in py38?
There was a problem hiding this comment.
That path was removed in nutmeg: openedx/edx-platform@8e8d840
https://github.com/openedx/edx-platform/tree/open-release/nutmeg.master/common/lib
There was a problem hiding this comment.
I see.
Now that it is located at openedx-calc
Symmath has been added to openedx-calc alongside calc in openedx/openedx-calc#38.
Do we need to allow it or install it or something else?
There was a problem hiding this comment.
As you said, it's now in py38.txt
| @@ -17,7 +17,7 @@ | |||
| "VERSION": __version__, | |||
| "HOST": "codejailservice", | |||
| "DOCKER_IMAGE": f"docker.io/ednxops/codejailservice:{__version__}", | |||
| "SANDBOX_PYTHON_VERSION": "3.5.10", | |||
There was a problem hiding this comment.
We changed it from 3.5 to 3.8 since the sandbox requirements didn't include py3.5 anymore.
Now, which patch version should we use here?
We first tried to use 3.8.6 but then changed it to 3.8.5 so it doesn't crash with the codejailservice pyenv (which also uses 3.8.6).
@felipemontoya @Alec4r @MoisesGSalas @jfavellar90 @johanv26
There was a problem hiding this comment.
maybe you can use pyenv-alias and install the sandbox version as x.y.z_sandbox ?
There was a problem hiding this comment.
That's a great suggestion! Thanks, I'll try that
mariajgrimaldi
assigned jfavellar90, Alec4r and MoisesGSalas and unassigned jfavellar90, Alec4r and MoisesGSalas
mariajgrimaldi
requested review from
Alec4r,
jfavellar90,
JuanDavidBuitrago,
johanseto and
MoisesGSalas
|
|
||
|
|
||
| # | ||
| # Whitelist particiclar shared objects from the system | ||
| # python installation | ||
| # | ||
| /sandbox/venv/** mr, | ||
| /opt/pyenv/versions/3.5.10/** mr, | ||
| /opt/pyenv/versions/3.[0-9].*/** mr, |
There was a problem hiding this comment.
Wasn't this intended for the sandbox version only? you can use {{ SANDBOX_PYTHON_VERSION }} right?
There was a problem hiding this comment.
That's right! Thanks
|
Can you review again please? @MoisesGSalas @felipemontoya |
|
|
||
|
|
||
| # | ||
| # Whitelist particiclar shared objects from the system | ||
| # python installation | ||
| # | ||
| /sandbox/venv/** mr, | ||
| /opt/pyenv/versions/3.5.10/** mr, | ||
| /opt/pyenv/versions/{{ CODEJAIL_SANDBOX_PYTHON_VERSION }}/** mr, |
There was a problem hiding this comment.
This should be {{ CODEJAIL_SANDBOX_PYTHON_VERSION }}_sandbox
There was a problem hiding this comment.
I totally missed that. Thanks
| @@ -20,7 +20,8 @@ ARG CODEJAILSERVICE_PYTHON_VERSION=3.8.6 | |||
| RUN $PYENV_ROOT/bin/pyenv install $CODEJAILSERVICE_PYTHON_VERSION | |||
|
|
|||
| ARG SANDBOX_PYTHON_VERSION={{ CODEJAIL_SANDBOX_PYTHON_VERSION }} | |||
| RUN $PYENV_ROOT/bin/pyenv install $SANDBOX_PYTHON_VERSION | |||
| RUN git clone https://github.com/s1341/pyenv-alias.git $PYENV_ROOT/plugins/pyenv-alias | |||
| RUN VERSION_ALIAS={{ CODEJAIL_SANDBOX_PYTHON_VERSION }}_sandbox $PYENV_ROOT/bin/pyenv install $SANDBOX_PYTHON_VERSION | |||
|
|
|||
| RUN $PYENV_ROOT/versions/$CODEJAILSERVICE_PYTHON_VERSION/bin/python -m venv /openedx/venv | |||
| RUN $PYENV_ROOT/versions/$SANDBOX_PYTHON_VERSION/bin/python -m venv --copies /sandbox/venv | |||
There was a problem hiding this comment.
| RUN $PYENV_ROOT/versions/$SANDBOX_PYTHON_VERSION/bin/python -m venv --copies /sandbox/venv | |
| RUN $PYENV_ROOT/versions/"$SANDBOX_PYTHON_VERSION"_sandbox/bin/python -m venv --copies /sandbox/venv |
There was a problem hiding this comment.
Good, thanks. I'll build the image and let you know how it goes
|
@mariajgrimaldi Has this fix been successful? The reason I ask is because it is a blocker to resolving this Nutmeg testing issue: openedx/wg-build-test-release#159 |
|
Yes @DeanJayMathew. I'm just waiting for an approval to merge and release. |
|
I've tested building a new image with the latest changes in the PR and it's working! Using the course attached here |
mariajgrimaldi
force-pushed
the
MJG/nutmeg
branch
from
a6ef8a3
to
acc467b
Compare
* Bump version 13.x to 14.x * Bump Python to 3.8 in sandbox environment * Add support for python 3.8 in the apparmor profile
mariajgrimaldi
force-pushed
the
MJG/nutmeg
branch
from
acc467b
to
b5dff67
Compare
Description
This PR adds nutmeg support:
How to test
Steps to reproduce the behavior: