Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to configure HPA and VPA for any service #5

Closed
wants to merge 1 commit into from

Conversation

Ian2012
Copy link
Member

@Ian2012 Ian2012 commented Sep 15, 2023

Description

This PR allows configuring HPA and VPA for multiple services. It's a backward-compatible change as the old variables are used as defaults for the CMS, LMS, LMS-WORKER, and CMS-WORKER.

Author concern:

  • After comparing the main branch vs. this PR, I only see one difference in the generated configuration. This is because the CMS was using the configuration for the CMS-WORKER.
 apiVersion: apps/v1
 kind: Deployment
@@ -44,11 +47,12 @@ spec:
         - name: cms
           resources:
             requests:
-              memory: 750Mi
-              cpu: 0.175
+              memory: 350Mi
+              cpu: 0.25
             limits:
-              memory: 3000Mi
+              memory: 1400Mi
               cpu: 1
+

Is this intended?

@jfavellar90
Copy link
Member

@Ian2012 for now I'm closing this PR. The changes you propose will cause the creation of multiple configurations that can be complicated to maintain. There's an open discussion here where we are discussing the best way to provide HPA for additional OpenedX services.

@jfavellar90 jfavellar90 deleted the cag/refactor-pod-autoscaling branch May 7, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants