Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier to the project #9

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

seog-jun
Copy link
Contributor

@seog-jun seog-jun commented Oct 6, 2023

Fixes #8

Hi, I created the PR to add Prettier to the project and added Husky and pretty-quick to apply Prettier automatically when you make git commits. Also, I updated scripts in package.json to add 2 commands: format and check-format, you can use the commands manually.

Let me know if there are files that you don't want to apply Prettier, and I can update .prettierignore file, it depends on your preference. Thanks

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storybook-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 5:30pm

Copy link
Owner

@eduardconstantin eduardconstantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice!
One small request, could you make the tabs shorter?

@seog-jun
Copy link
Contributor Author

seog-jun commented Oct 6, 2023

The current tabWidth is set to 4, do you want to make it 2?

@eduardconstantin
Copy link
Owner

The current tabWidth is set to 4, do you want to make it 2?

Yes, please!

Copy link
Owner

@eduardconstantin eduardconstantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thank you!

@eduardconstantin eduardconstantin merged commit 8c5dae4 into eduardconstantin:main Oct 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add prettier
2 participants