Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more browsers to the overview #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add more browsers to the overview #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ebe54b
Use browser names directly from MDN data
Jun 3, 2018
0ef0731
Add missing browsers to the overview
Jun 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion src/components/Overview.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,39 @@ class Overview extends Component {
<Browser
browser='edge'
/>
</div>

<Browser
browser='safari'
/>

<Browser
browser='firefox_android'
/>

<Browser
browser='edge_mobile'
/>

<Browser
browser='safari_ios'
/>

<Browser
browser='samsunginternet_android'
/>

<Browser
browser='qq_android'
/>

<Browser
browser='uc_android'
/>

<Browser
browser='uc_chinese_android'
/>
</div>
)
}
}
Expand Down
11 changes: 4 additions & 7 deletions src/lib/Browsers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,10 @@ const BrowserList = function () {
return browsers
}, {})

this.browserNames = {
chrome: 'Chrome',
opera: 'Opera',
firefox: 'Firefox',
ie: 'IE',
edge: 'Edge'
}
this.browserNames = Object.keys(compatData.browsers).reduce((browsers, browser) => {
browsers[browser] = compatData.browsers[browser].name
return browsers
}, {})
}

BrowserList.prototype.get = function (handle) {
Expand Down