Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Added an interval for empty unit #134

Merged
merged 1 commit into from
Jun 19, 2016

Conversation

KittyGiraudel
Copy link
Collaborator

This PR allows media queries using unitless values, such as aspect-ratio:

.foo {
  @include media('aspect-ratio>1') {
    color: red;
  }
}

It would previously throw this error:

Unknown unit ``.

Ping @eduardoboucas.

@eduardoboucas
Copy link
Owner

Happy with this!

@eduardoboucas eduardoboucas merged commit e1c46fa into master Jun 19, 2016
@KittyGiraudel
Copy link
Collaborator Author

Could you please release?

@eduardoboucas
Copy link
Owner

Will do.

@eduardoboucas eduardoboucas deleted the feature/unitless-interval branch July 28, 2016 10:21
@sertaconay
Copy link

Are you sure that aspect-ratio accepts integer value?
https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries#aspect-ratio
https://www.w3.org/TR/css3-mediaqueries/#aspect-ratio

May I ask how we can write 'aspect-ratio: 4/3'?

@KittyGiraudel
Copy link
Collaborator Author

I won’t have time to tackle this question. Ping @eduardoboucas. :)

@eduardoboucas
Copy link
Owner

Really short on time as well. Will try to have a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants