Adds support for Spaces #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be fair, you did even better than I would have. I’ll let @eduardoboucas have the last call and merge but for me it’s beyond perfect. |
|
It's literally your code that I copy-pasted, so you gotta give yourself more credit than that haha. |
|
Ditto! Really happy with it. Thanks @IanMitchell! Probably won't have a chance to merge and release today, but will do that first thing tomorrow. |
|
No rush! Thanks for the library :) |
|
Done! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this tweet it seems like there wasn't a conscious decision to not allow
op variablesyntax (for example>= phone) so I went ahead and took a pass at implementing it. Full credit to Hugo for thetrimandfirst-indexmethods - I ripped them straight out ofsass-semver. First time I've really done something intense in Sass, but gave it my best shot - please let me know if I broke styleguide somewhere 😄