Fix sass division warnings #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @alexanderalmstrom can you check that this works with node-sass too? Otherwise might change the destination branch to 2.0-release branch |
|
@jackmcpickle Yes. Good point. I've checked and it does not work with node-sass. You will need at least sass@1.33.0 where the Lets make 2.0-release the destination branch. |
|
The 2.0 release branch is there mate. Change it to that and I'll merge it in. But planning on a bunch of other package updates on top. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade from node-sass to sass@1.45.0 (dart-sass) and fix division warnings.