Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is API call rate limit for all users ? #242

Closed
gourav opened this issue Dec 9, 2018 · 3 comments
Closed

Is API call rate limit for all users ? #242

gourav opened this issue Dec 9, 2018 · 3 comments

Comments

@gourav
Copy link

gourav commented Dec 9, 2018

GitHub API call limit is restricted to 5k/hour. Is this limit for all users ? I mean for everyone using the public staticman API instance ?

With this, for a single pull request, app will consume at least 4 Github API call quota for a single comment process request ?

If that is the case, the maximum amount of comment requests that public instance of StaticMan can serve is restricted around ~1k/hr, which means other than first 1k comment requests, all other comment requests are ignored by GitHub ?

Is that the case ?

@robinmetral
Copy link

It is. Currently the public instance of Staticman is not scalable.

Some solutions include using Gitlab, or self-hosting your Staticman instance (see #222, #227). Or maybe we could make the public instance scalable by making it a Github app (#243)

@gourav
Copy link
Author

gourav commented Dec 12, 2018

#243,
In process.

@eduardoboucas
Copy link
Owner

Closing in favour of #243. Thanks!

caiopavanelli pushed a commit to caiopavanelli/staticman that referenced this issue Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants