Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code modernization #249

Open
maciek134 opened this issue Dec 30, 2018 · 1 comment
Open

Code modernization #249

maciek134 opened this issue Dec 30, 2018 · 1 comment
Labels
feature request help wanted Signifies that the maintainers of the project would like assistance with this problem.

Comments

@maciek134
Copy link
Contributor

maciek134 commented Dec 30, 2018

I took a look at the source code while working on #243 (comment) and I see that some of it looks old - creating classes with function and .prototype..., promises instead of async/await. If I rewrite the codebase to use more modern JS features will a PR with it be accepted?

A bit off topic, but why StandardJS? The lack of semicolons gives me shivers whenever I look at the code ;p

@alexwaibel
Copy link
Collaborator

Yeah, this code is using old standards and styles. At some point, I'd like to move to the Airbnb style guide and convert the whole thing to ES6 but that's a low priority task for the time being. I do find it important to modernize our style as the current standards are very difficult to read in my opinion and will deter open source contributions if we don't fix it.

@alexwaibel alexwaibel added feature request help wanted Signifies that the maintainers of the project would like assistance with this problem. labels Nov 8, 2019
caiopavanelli pushed a commit to caiopavanelli/staticman that referenced this issue Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request help wanted Signifies that the maintainers of the project would like assistance with this problem.
Projects
None yet
Development

No branches or pull requests

2 participants