Allow for customizing the name of the sender to put on notification emails #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mails, something other than "Staticman". - Added email.fromName to the JSON config schema. - Updated config schema doc to remove reference to non-existent notifications.fromAddress parameter in the site config. - Updated unit test.
|
Nice! However, given our other discussion regarding |
|
For the sake of this PR it's fine to add I agree we should consider moving these into the site config YAML at some point though. I think there's already an issue open regarding this (at least for the akismet properties). |
JonBoyleCoding
pushed a commit
to JonBoyleCoding/staticman
that referenced
this pull request
Feb 6, 2023
…mails, something other than "Staticman". (eduardoboucas#393) - Added email.fromName to the JSON config schema. - Updated config schema doc to remove reference to non-existent notifications.fromAddress parameter in the site config. - Updated unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #392 - "Provide support for customizing the name of the sender on notification emails".
The changes for this are minimal.
While in there, I corrected the doc for the email.fromAddress property.
The relevant unit test has been updated. I performed integration testing on Heroku.
The changes here overlap with changes made for PR #391. If that PR is merged-in before this one and that makes this merge burdensome, please LMK and I can re-create this PR. If/when this is merged-in, I'll be happy to submit a PR to update the documentation site.
Thank you for Staticman!