Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use es6/7 babel #234

Closed
sibelius opened this issue Jul 11, 2017 · 4 comments
Closed

use es6/7 babel #234

sibelius opened this issue Jul 11, 2017 · 4 comments

Comments

@sibelius
Copy link
Contributor

No description provided.

@jeromeetienne
Copy link
Collaborator

it wont provide any feature advantage and require a whole rewrite. Lets focus on pragmatic advances which add more to the user.

there is way enougth to do already :)

@sibelius sibelius mentioned this issue Oct 23, 2017
Closed
@sibelius
Copy link
Contributor Author

I think using es6/7 with babel would bring more contributors for this package

it is not working with react native for now (#188)
because depends on web stuff, like document

@jgcmarins
Copy link

@jeromeetienne any chances to reopen this one?

@sibelius
Copy link
Contributor Author

would u accept a PR to gradually move this to es6 and babel?

sibelius added a commit to sibelius/tracking.js that referenced this issue Apr 18, 2018
@sibelius
chore(babel): setup babel to enable newer javascript code, fix eduard…
1bd9c77 
…olundgren#234, fix eduardolundgren#177
eduardolundgren pushed a commit that referenced this issue Apr 19, 2018
@sibelius @eduardolundgren
chore(babel): setup babel to enable newer javascript code, fix #234, fix
76e9f4b 
 #177 (#301)
eduardolundgren added a commit that referenced this issue Apr 19, 2018
@eduardolundgren
Revert "chore(babel): setup babel to enable newer javascript code, fix …
933d6a6 
…#234, fix #177 (#301)"

This reverts commit 76e9f4b.
eduardolundgren pushed a commit that referenced this issue Apr 19, 2018
@eduardolundgren
Revert "chore(babel): setup babel to enable newer javascript code, fix …
6cea667 
…#234, fix #177 (#301)"

This reverts commit 76e9f4b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeromeetienne @sibelius @jgcmarins