Skip to content

Commit

Permalink
feat: use fingering element by default (#25)
Browse files Browse the repository at this point in the history
For newer versions of MuseScore (>3.5), we will use the fingering
elements by default instead of a staff text.
  • Loading branch information
eduardomourar committed Sep 10, 2022
1 parent 64d440a commit 9f4a44f
Show file tree
Hide file tree
Showing 6 changed files with 2,831 additions and 2,993 deletions.
32 changes: 32 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: release

on:
release:
types: [published]

jobs:
publish:
if: ${{ github.event.release.draft == true }}
runs-on: ubuntu-latest
permissions:
contents: write

steps:
- name: Check name and tag
run: |
echo 'name: ${{ github.event.release.name }}'
echo 'tag_name: ${{ github.event.release.tag_name }}'
exit 1
- uses: actions/checkout@v3

- name: Add files and publish release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TAG_NAME: ${{ github.event.release.tag_name }}
run: |
VERSION=$(echo $TAG_NAME | sed -e 's/^v//')
sed -i '' "s/__VERSION__/${VERSION}/" fingeringdiagram.qml
zip fingering-diagram-${TAG_NAME}.zip fingeringdiagram.qml LICENSE README.md
gh release upload ${TAG_NAME} fingering-diagram-${TAG_NAME}.zip
gh release edit --draft=false ${TAG_NAME}
53 changes: 53 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
## [1.6.0](https://github.com/eduardomourar/fingering-diagram/compare/v1.5.0...v1.6.0) (2021-04-25)


### Bug Fixes

* Fix for "Method names cannot begin with an upper case letter" ([#23](https://github.com/eduardomourar/fingering-diagram/issues/23)) - Thanks to @nucklearproject

## [1.5.0](https://github.com/eduardomourar/fingering-diagram/compare/v1.4.0...v1.5.0) (2020-11-25)


### Features

* Support for Tuba fingering ([#22](https://github.com/eduardomourar/fingering-diagram/issues/22)) - Thanks to @schuellerf
* Support for Clarinet fingering ([#2](https://github.com/eduardomourar/fingering-diagram/issues/2)) - Thanks to @gusmoney

## [1.4.0](https://github.com/eduardomourar/fingering-diagram/compare/v1.3.0...v1.4.0) (2020-09-16)


### Bug Fixes

* Fix Tenor and Baritone Saxophone transposition ([#19](https://github.com/eduardomourar/fingering-diagram/issues/19)) - Thanks to @gusmoney

## [1.3.0](https://github.com/eduardomourar/fingering-diagram/compare/v1.2.0...v1.3.0) (2020-06-27)


### Features

* Support for Alto Recorder ([#17](https://github.com/eduardomourar/fingering-diagram/issues/17)) - Thanks to @eduardobaitello

## [1.2.0](https://github.com/eduardomourar/fingering-diagram/compare/v1.1.0...v1.2.0) (2020-02-06)


### Features

* Support for Saxophone diagrams ([#5](https://github.com/eduardomourar/fingering-diagram/issues/5)) - Thanks to @Khrisbie

## [1.1.0](https://github.com/eduardomourar/fingering-diagram/compare/v1.0.0...v1.1.0) (2020-01-21)


### Features

* Support for Low and Tin Whistles diagrams ([#9](https://github.com/eduardomourar/fingering-diagram/issues/9)) - Thanks to @jgadsden
* Support for Xaphoon diagrams ([#10](https://github.com/eduardomourar/fingering-diagram/issues/10)) - Thanks to @skuntzmann

## [1.0.0](https://github.com/eduardomourar/fingering-diagram/tree/v1.0.0) (2020-01-06)


### Features

* Use the Fiati music font
* Add Flute, Piccolo, Recorder diagram
* Generic fingering that can be used for clarinet, oboe, bassoon, saxophone, etc

6 changes: 3 additions & 3 deletions fingeringdiagram.qml
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
// Requires Fiati music font that can found here:
// https://github.com/eduardomourar/fiati
//
// Copyright (c) 2019-2020 Eduardo Rodrigues
// Copyright (c) 2019-2022 Eduardo Rodrigues
//=============================================================================
import QtQuick 2.9
import QtQuick.Dialogs 1.1
import MuseScore 3.0

MuseScore {
menuPath: 'Plugins.Fingering Diagram'
version: '1.6'
version: '__VERSION__'
description: 'Add instrument fingering diagrams to the score'
requiresScore: true

Expand Down Expand Up @@ -518,7 +518,7 @@ MuseScore {
var endTick;
var fullScore = false;
var elementType;
var supportFingeringElement = false; // (mscoreVersion >= 30500);
var supportFingeringElement = (mscoreVersion >= 30500);
var staffChanged = 0;
var staffFound = [];

Expand Down
2 changes: 1 addition & 1 deletion release-please-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"release-type": "simple",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"draft": false,
"draft": true,
"prerelease": false
}
}
Expand Down
Loading

0 comments on commit 9f4a44f

Please sign in to comment.