Greeting npc on left click #1150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmichalski
suggested changes
May 18, 2021
| @@ -502,6 +502,10 @@ function onBattleButtonMouseRelease(self, mousePosition, mouseButton) | |||
| if self.isTarget then | |||
| g_game.cancelAttack() | |||
| else | |||
| if self.creature:isNpc() then | |||
There was a problem hiding this comment.
IMHO this behaviour should also be configurable through a checkbox in options. There might be servers that allows attacking an NPC.
| if creatureThing:getPosition().z == localPosition.z then | ||
| if g_game.getAttackingCreature() ~= creatureThing then | ||
| menu:addOption(tr('Attack'), function() g_game.attack(creatureThing) end, shortcut) | ||
| if creatureThing:getPosition().z == localPosition.z then |
There was a problem hiding this comment.
Spacing seems to be off.
| checkMaxDistanceToGreetingNpc(player, creatureThing) | ||
| return true | ||
| end | ||
| end |
There was a problem hiding this comment.
This does not seem to be right. Won't this trigger greeting by clicking any mouse button on any NPC (different floor level [pos.z])?
This should probably be implemented at those branches in the above checks (classic/non-classic controls):
elseif creatureThing and creatureThing:getPosition().z == autoWalkPos.z
| @@ -896,3 +911,11 @@ end | |||
| function limitZoom() | |||
| limitedZoom = true | |||
| end | |||
|
|
|||
| function checkMaxDistanceToGreetingNpc(creaturePlayer, creatureNpc) | |||
There was a problem hiding this comment.
This is not really a check when it triggers an action, is it? :)
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to choose a max distance to talk him
maxDistanceToGreetingNpc = 3Table with greetings words
focusGreetWords = {"hi", "hello"}Random the words
g_game.talk(focusGreetWords[math.random(1, #focusGreetWords)])Change a right click option on npc, attack option to talk option.
https://github.com/edubart/otclient/compare/master...alfuveam:greeting_npc_hi?expand=1#diff-1b975e904a1c9756dc22f83fbc9884012958e3c3f158bc081aaa6c49dfa2f585L557-R569