Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed items minimap color and battle square #865

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erexo
Copy link

@erexo erexo commented Aug 28, 2017

Some items marked as "common" are actually an important terrain items (like doors/fences/street lamps and so on). It makes minimap much more readable if every item with minimap color is shown (as in Cip client).

@erexo erexo closed this Sep 27, 2017
@erexo erexo reopened this Sep 27, 2017
@erexo erexo changed the title Fixed items minimap color Fixed items minimap color and battle square Sep 27, 2017
@erexo
Copy link
Author

erexo commented Sep 27, 2017

Known bug;
Since there is one opcode from server that tells to stop both attacking and following, when player is following a creature and decide to attack other, the client will remove attacked crature and add followed, trigger event that we are not attacking anything now so server send us back this cancel opcode so client cancel the follow and we end up with nothing. Cip client somehow managed to pass through it

@erexo erexo force-pushed the master branch 2 times, most recently from 6f03787 to 7ce5bca Compare September 28, 2017 08:48
@Felipe1993
Copy link

so this passed or not?

@andersonfaaria
Copy link
Contributor

Instead of deleting the if statement you should have checked for the specified items. If this is merged we will have to iterate through every item to draw it on map, which would be very bad. Also you should make different branches for different commits instead of just make one pull request with lots of commits. As for the bug of attacking who you are following, I'll test it to confirm

@pasturryx
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants