Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Assignments with starter code show as "Submitted" even when students have not pushed changes. #2566

Open
lizfischer opened this issue Feb 25, 2020 · 1 comment

Comments

@lizfischer
Copy link

lizfischer commented Feb 25, 2020

Describe the bug
When assignments have starter code from which student repositories are created, assignments are marked as "Submitted" whether or not the student has pushed any of their own work. Because Classroom interprets the last commit before the deadline as a submission, the initial commit that populates the repositories with the starter code is counted.

To Reproduce
Create an assignment with starter code.
Set a deadline.
Have students accept the assignment but not push any changes.

Expected behavior
I would expect only students who have pushed their own work (>1 commit for assignments with starter code, > 0 for assignments without starter code) before the deadline to be counted as submissions.

Screenshots
Actual
image

Expected
image

Additional context
This seems related to but distinct from some of the items mentioned in #2488. Also possibly related to #1353

@d12
Copy link
Contributor

d12 commented Mar 11, 2020

Hey @lizfischer , thanks for the report! We've added this to our list of things TODO, hopefully we'll fix this up soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants