This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Rename Assignment::RepositoryVisibilityJob to a single class #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessRudder
approved these changes
Aug 9, 2019
jeffrafter
deleted the
jr-duplicate-and-rename-repository-visibility-job
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have two definitions of the
Assignmentclass and this tends to break auto-loading in unexpected ways. This PR renamesAssignment::RepositoryVisibilityJobtoAssignmentRepositoryVisibilityJobmaking it no-longer-nested. This keeps the concerns of Jobs and Models separate.Because this PR renames a Job we need to deploy the fix in multiple steps:
This should fix the
Assignmenterrors which led to today's maintenance mode.