This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Validate Grouping while validating GroupAssignment #2232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2230.
Problem
Grouping
s are persisted when their associatingGroupAssignment
is saved, however, if the grouping fails its validation the group assignment will still save with a nil grouping_id.Solution
Use the
validates_associated
helper onGroupAssignment
to validate the grouping as part of the assignment's validation. I've also added a couple methods to fetch the errors straight from the grouping object sincevalidates_associated
only adds a genericYour grouping is invalid
error message on the group assignment object.