Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance fast_predict by requiring fewer arguments (just the model) #631

Closed
mulhod opened this issue Jul 31, 2023 · 1 comment · Fixed by #632
Closed

Enhance fast_predict by requiring fewer arguments (just the model) #631

mulhod opened this issue Jul 31, 2023 · 1 comment · Fixed by #632
Assignees

Comments

@mulhod
Copy link
Contributor

mulhod commented Jul 31, 2023

It would be nice if we could make feature_info, trim_min, trim_max, and trim_tolerance attributes of the Modeler object. We can still expose these things in the fast_predict function. We could use the values if they are provided and not None. Otherwise, we check for the presence of these attributes and, if specified, use them instead. For feature_info, it must be able to be found as an attribute if None/not specified in the call to fast_predict. For trim_min/trim_max, if it's both None/unspecified and cannot be found as an attribute, the default value None will be used for (no trimming). For trim_tolerance, if it's both None/unspecified and cannot be found as an attribute, the default value of 0.4998 will be used.

This should make it possible to call fast_predict with only the data and a Modeler object.

@mulhod mulhod self-assigned this Jul 31, 2023
@mulhod
Copy link
Contributor Author

mulhod commented Jul 31, 2023

Actually, I will look into adding train_predictions_mean, etc., as well. Anything, basically, that could be added as an attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants