Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback command #23

Open
edudobay opened this issue May 12, 2019 · 0 comments
Open

Rollback command #23

edudobay opened this issue May 12, 2019 · 0 comments

Comments

@edudobay
Copy link
Owner

edudobay commented May 12, 2019

Depends on having a deployment log (#20).

Constraints:

  • Will yield an error if no previous deployment exists.
  • If the build for the previous deployment does not exist, we cannot do a strict rollback.
    • One possibility is to fail unless the --allow-rebuild option is given; then the build will be re-run against the original git commit.
    • We could instead fail and tell the user what they should do instead:

      Build for previous deployment is no longer available. If you want to rebuild it, run

      simple-git-deploy deploy --ref-name NAME_OF_PREVIOUS_REF \
        --ref COMMIT_REF` \
        --message "Rollback to new build for deployment DEPLOYMENT_ID"
      
    • If the original git commit does not exist anymore, this cannot succeed in any way.

Questions

  • Do we need to have special procedures for undoing a deployment?
    • I believe we can live without that; it probably would make our process too complex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant