Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still dealing with the fallout from the bad SDK 7.0.200 release #58

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

edumserrano
Copy link
Owner

@edumserrano edumserrano commented Mar 9, 2023

The release of dotnet SDK 7.0.200 broke my build pipeline because a preview version of MSBuild started being used.
Previous commits fixed the issue by:

  • pinning the SDK version to 7.0.103 until a fix for MSBuild is released.
  • updating dev README with a note about global.json.
  • updating the pipelines to make sure the global.json file is respected.
    • the setup-dotnet action now uses the global.json to determine which version of dotnet to install.
    • the dotnet CLI commands now run from the directory where global.json is. Previously they were run from a directory above and the CLI will only search the current directory and above.

This PR now updates the Dockerfile to install SDK 7.0.103 because a new image has been published that moved the SDK installed from 7.0.103 to 7.0.201. Due to the tag I'm using on the Dockerfile that latest image was picked up and broke the pipeline again.

Related issues:

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #58 (e97d7d6) into main (6d422be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          67       67           
  Lines         980      980           
  Branches       72       72           
=======================================
  Hits          937      937           
  Misses         32       32           
  Partials       11       11           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edumserrano edumserrano enabled auto-merge (squash) March 9, 2023 12:47
@edumserrano edumserrano merged commit 3e1cce4 into main Mar 9, 2023
@edumserrano edumserrano deleted the dockerfile branch March 9, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant