Refactor iTunes tags for April 2019 changes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a number of breaking changes in this commit that is required for the iTunes tag updates. There is also a lot of new logic coming (in future commits) that is required to parse the tags properly. This is an initial draft. More plumbing is required, as well as reworking all Examples and tests. One bit of good news: lots of new documentation is now available on iTunes. So I've added a lot of it here.
eduncan911
force-pushed
the
refresh-itunes-tags
branch
from
2873208
to
dc4ad45
Compare
|
I gave this branch a whirl but it failed with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a number of breaking changes in this commit that is required for the iTunes tag updates.
AddAuthor()that will now instead setIOwner.Emailand.Name, instead ofAuthor- leaving Author to be the new name (without email) per April 2019 suggestions.This is an initial draft. More plumbing is required, as well as reworking all Examples and tests.
One bit of good news: lots of new documentation is now available on iTunes. So I've added a lot of it here.