Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spanish translation #324

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Conversation

kakopedreros
Copy link
Contributor

Hi!

this pull request provide a Spanish for Latinamerica (es_419) translation of the file locates in the "app/src/main/res/values" folder.

I follow the instructions provided by @dzolnai in the issues #323.

I'll await further instructions.

Best regards,

@kakopedreros kakopedreros changed the title Add spanish translation #323 Add spanish translation Apr 10, 2021
@dzolnai
Copy link
Collaborator

dzolnai commented Apr 12, 2021

Hi, I have checked the translation and it looks good, the app builds fine.
One minor thing: there's one strings.xml file left I forgot to mention to you:
In app/src/home/res/values/. You have to create a values-es the same way you did with the other files.

And I have a question: do you need us to make a release after merging a PR? I don't think there is currently a new release in the planning, so it might be months if we would pick this up with the next update.

@ghost
Copy link

ghost commented Apr 12, 2021

I don't think there is currently a new release in the planning, so it might be months if we would pick this up with the next update.

I can make a new release at any time really, so that's not a problem :)

@kakopedreros
Copy link
Contributor Author

kakopedreros commented Apr 13, 2021

Hi, I have checked the translation and it looks good, the app builds fine.

Great!

One minor thing: there's one strings.xml file left I forgot to mention to you:
In app/src/home/res/values/. You have to create a values-es the same way you did with the other files.

Done!

=)

Best regards,

@kakopedreros
Copy link
Contributor Author

I don't think there is currently a new release in the planning, so it might be months if we would pick this up with the next update.

I can make a new release at any time really, so that's not a problem :)

If it's posible that would be great. We would start the massive use of this platform and having the clients translated would reduce the frustration of the users.

Thanks in advance.

=)

@dzolnai
Copy link
Collaborator

dzolnai commented Apr 13, 2021

I have checked eduVPN and Let's Connect, both seem to be working fine.
Thanks for your work!

@dzolnai dzolnai merged commit 2d20feb into eduvpn:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants