Update dependencies

[boergegrunicke]

Hi,
next idea: it would be cool if the updater would automatically update the manifest file so if we update a dependency library or other files that they could be included via a regular update and the application must not be installed completely new.

[edvin]

I don't think I understand you mean. You normally ship your application with just the manifest and the launcher, and the manifest is updated every time. If you also ship with your dependencies, they will be updated as soon as you provide newer versions of them. What do you mean by "update would automatically updated the manifest file?". As far as I can understand, that already happens :)

[boergegrunicke]

in the manifest file are all the libs included that should be updated, if i now add a file that should be included in updates it should be able to add them even if the client does not now them

[edvin]

Ah, so even though it downloads the new manifest, you only get updates of the libraries mentioned in the old manifest? That should be easy to fix. I'll have a look tonight and report back.

[boergegrunicke]

for me it seems so...
this would be very good

[edvin]

Looking at the code (and the intended behavior), this is exactly how it is designed. You can see that it downloads the new manifest, and iterates over the files found in the new manifest. This should result in all new files being downloaded, regardless of whether they were previously available or not.

However, it doesn't currently remove unneeded files - can that be what's causing the issue for you?

[edvin]

Version 1.0.12 should hit Maven Central any time now :) I'm anxious to hear back from you about this issue as I can't seem to recreate it. Let me know when you have something.

[boergegrunicke]

now i tested a bit with the 1.0.12 version. it updated fine until i added a new library. the "create-manifest" task included it into the manifest but the client did not update its own manifest it still updated the already included libs but did not add the new ones and generally it did not update the timestamp.

[edvin]

When you say the manifest is not updated, you're referring to the manifest in the cache dir, right? The manifest inside the jar is never updated, but the manifest saved in the cache dir should absolutely update. If this is the case, I'll investigate further.

[boergegrunicke]

i am refering to the manifest in the cachdir, not the one in the jar, and for me it seemed not like it has been updated ...

[edvin]

OK, thanks for getting back to me. I'll investigate further tonight and let you know what I find.

[edvin]

I can confirm that I see the same behavior. Working on it now :)

[edvin]

I found the issue - when one of the manifests are missing the timestamp, the isNewerThan call always returned false. So this was an issue the first time you generate the manifest and deploy. I have fixed it so it will work on the first try :)

[edvin]

If you time - can you check if this works as expected with version 1.0.13?

[boergegrunicke]

okay now i tested with the 1.0.13 version. now it detects the files that should be included and uploads them to the scp-server but the entry <include-extensions> does not appear in the manifest file and the included file dies not get downloaded on application start by the launcher

[edvin]

Sorry for taking so long again. The <include-extensions> should not appear in the manifest, the files that match include-extensions should get their own ` entry in the the manifest. Can you confirm that that's the case?

I'm setting up a test case locally in the mean time.

[edvin]

I found the bug and have committed a fix to 1.0.14-SNAPSHOT. Let me know if you have a chance to test it :)