Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n Support #29

Closed
edvin opened this issue Feb 29, 2016 · 12 comments
Closed

i18n Support #29

edvin opened this issue Feb 29, 2016 · 12 comments
Assignees

Comments

@edvin
Copy link
Owner

edvin commented Feb 29, 2016

TornadoFX should provide an easy way to work with multiple UI languages.

@edvin edvin self-assigned this Mar 1, 2016
@edvin
Copy link
Owner Author

edvin commented Mar 2, 2016

I want to create some kind of convention so you don't need to specify the resource bundle for each Component, but it should be possible to override. I'd like a global Resource bundle, and the possibility for a bundle per Component with fallback to the global bundle.

Need to figure out how to deal with changes to locale when the app is running, and if we should configure locale somewhere in the framework, or just use the default locale.

edvin pushed a commit that referenced this issue Mar 2, 2016
@edvin
Copy link
Owner Author

edvin commented Mar 2, 2016

Implementation complete. Will document here tomorrow: https://github.com/edvin/tornadofx/wiki/i18n

@edvin edvin closed this as completed Mar 2, 2016
@edvin
Copy link
Owner Author

edvin commented Mar 2, 2016

Documentation available. Do you have the time to try the functionality and look at the documentation @thomasnield ? Would love some input!

@thomasnield
Copy link
Collaborator

Sure I'll give a spin. I'll be out tonight playing but I can make some time tomorrow. I'm not familiar with internationalization so this will be a learning moment for me!

@thomasnield
Copy link
Collaborator

Yeah this looks pretty interesting. I'll take a look as soon as I can.

@edvin
Copy link
Owner Author

edvin commented Mar 2, 2016

Cool! Bear in mind, I didn't know how to do i18n in JavaFX before today either, but I've used it a lot in JSF. Nothing is set in stone, so let me know what you think. Enjoy your night out :)

@thomasnield
Copy link
Collaborator

Thanks! Will do. Have a good night.

@edvin
Copy link
Owner Author

edvin commented Mar 2, 2016

You too, Thomas!

@thomasnield
Copy link
Collaborator

Sorry been bogged down today. Needed to modify TableFilter in ControlsFX today for an app at work. Since my time got spent there, I'll follow up with this, #33, and #32 tomorrow and this weekend.

@edvin
Copy link
Owner Author

edvin commented Mar 3, 2016

No worries @thomasnield - this is supposed to be fun, not a burden :) Got your email, will get back to you soon - I have some ideas!

@thomasnield
Copy link
Collaborator

Oh no worries I'm having a lot of fun! And I look forward to hearing, I think we could do a lot with ControlsFX and make some functionality with it when we are ready.

edvin pushed a commit that referenced this issue Mar 4, 2016
@thomasnield
Copy link
Collaborator

I've never done internationalization with software but this is pretty fascinating. I'll need to play with this more. Can you show me a full example with a View and a single button that is translated from one language to another?

This might be worthwhile to learn because my company is increasingly going international.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants