Fix symlinks that point to the old virtual env #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| version_info = (0, 2, 4) | ||
| version_info = (0, 2, 6) |
There was a problem hiding this comment.
I took the liberty of bumping the version. I choose 0.2.6 because the official pip release is 0.2.5
|
Hello @edwardgeorge did you have time to consider my pull request? |
edwardgeorge
added a commit
that referenced
this pull request
Jun 7, 2015
Fix symlinks that point to the old virtual env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, congrats for the nice tool. It saves us a lot of time!
Sometimes the source virtual environment has symlinks that point to itself
the issue I had were:
$OLD_VIRTUAL_ENV/local/lib points to $OLD_VIRTUAL_ENV/lib
$OLD_VIRTUAL_ENV/local/bin points to $OLD_VIRTUAL_ENV/bin
which was causing pip to complain about updating the packages because they were out of the virtual environment.
this pull request makes sure
$NEW_VIRTUAL_ENV/local/lib will point to $NEW_VIRTUAL_ENV/lib
I also took the liberty to bump the version to 0.2.6
if possible, please release a new version on pypy because this would make our life easier.