Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3.7 support and remove forgetten 3.3 parts #43

Closed
wants to merge 2 commits into from

Conversation

usta
Copy link
Contributor

@usta usta commented Jan 7, 2019

In general just fixes test configs and setup.py , trivial changes

In general just fixes test configs and setup.py , trivial changes
@timabbott
Copy link
Collaborator

@usta thanks for the contribution. Can you figure our the CI failure?

@usta
Copy link
Contributor Author

usta commented Jan 7, 2019

@timabbott It was a problem about travisCI without using xenial and sudo rights python 3.7 CI couldn't work. ( Python 3.7 requires OpenSSL 1.0.2+ and only xenial have that version )
So until xenial became default we have 2 options :
1- whether we need to especially run 3.7 tests on xenial others on trusty (just like right now )
2- OR I will change it to run all tests ( 2.7 , 3.4 , 3.5 , 3,6 , 3.7 ) will run on xenial

@timabbott
Copy link
Collaborator

I think it'd be reasonable to just upgrade to Xenial for CI, since Trusty will be EOL soon.

Use xenial with sudo rights on TravisCI
@usta
Copy link
Contributor Author

usta commented Jan 8, 2019

@timabbott so this PR done these things :

  • Move CI system to Xenial that will enable us to test 3.7 and others together and much recent platform
  • Adds py 3.7 support for setup.py
  • Adds py37 env into tox.ini
  • Removes 3.3 and adds 3.6 and 3.7 versions into test/init.py

@timabbott
Copy link
Collaborator

Merged as the commits ending with e49954e, thanks @usta!

@timabbott timabbott closed this Jan 8, 2019
@timabbott
Copy link
Collaborator

@eeshangarg can you do a release to offer 3.7 support soon?

@usta usta deleted the add_py37_remove_py33 branch January 9, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants