Made the class instanceable and made the requests streamable. (resolved issues 10 and 11) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Capitalized 'github3' to 'Github3' since it is an instanceable class now. 2) Updated constructor to take options. 3) Moved default values to constructor. 4) Added createInstance function which exports an instance of Github3. 5) Also, changed the module.exports to support backwards compatibility for now (by exporting an instance of Github3), but it should be updated in the future (please read the comment above module.exports). 6) Moved all methods to prototype (so they can be used in the instances). 7) Updated internal 'github3' references to 'this'. 8) Trimmed whitespace and added missing semicolons.
1) Methods now return the request object full through. 2) Removed method requirements for callback functions (by defaulting callback to noOp).
edwardhotchkiss
pushed a commit
that referenced
this pull request
Jun 9, 2012
Made the class instanceable and made the requests streamable. (resolved issues 10 and 11)
|
Publishing in 5, thanks :P |
This was referenced Jun 9, 2012
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes I made to this module should be fully backwards compatible, but please take special notice to commit1-5 (below).
Summary of Changes:
[commit1] Made the class instanceable.
[commit2] Added support for streams.