Optimized checkExists query

Now 30x faster!
edwardhotchkiss · Dec 21, 2011 · 4a15a26 · 4a15a26
1 parent d59b2a7
commit 4a15a26
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/models/ShortURL.js b/models/ShortURL.js
@@ -23,14 +23,12 @@ var ShortURL = mongoose.model("ShortURL", ShortURLSchema);
 
 // return count, if it exists, try another
 ShortURL.checkExists = function(hash, callback) {
-  var query = ShortURL.find({});
-  query.where("hash", hash);
-  query.exec(function(error, shortenedURLS) {
+  var query = ShortURL.find({"hash": hash}, [hash], function (error, shortenedURLS) {
     if (error) {
       callback(error, null);
     } else {
       callback(null, shortenedURLS);
-    };
+    }
   });
 };
 
@@ -47,12 +45,12 @@ ShortURL.findByHash = function(hash, callback) {
             callback(error, null);
           } else {
             callback(null, URL);
-          };
+          }
         });
       } else {
         callback(null, null);
       }
-    };
+    }
   });
 };