Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Commit

Permalink
Asset dependency clean up
Browse files Browse the repository at this point in the history
## remove webpack-jquery-ui, add jquery

When I originally switched to webpacker, I needed to add jquery which
is a supporting library for my custom jquery-ui build which lets me
drag and drop to sort items on the backend. The webpack one adds tons
of depencencies, where as jquery is just one.

## remove normalize.css

I wasn't able to get normalize.css imported from the node modules, but
I also removed it and it didn't seem to break anything. So I'm going to
keep it removed, as well as remove the `normalize-rails` gem.

## remove esbuild-sass-plugin

Finally, I was able to remove the `esbuild-sass-plugin` node module
since I'm not using esbuild to bundle sass anymore.
  • Loading branch information
edwardloveall committed Sep 1, 2022
1 parent 5d9eab5 commit 651f696
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 529 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ gem "image_processing"
gem "jbuilder"
gem "jsbundling-rails"
gem "kaminari"
gem "normalize-rails"
gem "oath"
gem "pg"
gem "puma"
Expand Down
2 changes: 0 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ GEM
racc (~> 1.4)
nokogiri (1.13.7-x86_64-linux)
racc (~> 1.4)
normalize-rails (8.0.1)
oath (1.1.0)
bcrypt
rails
Expand Down Expand Up @@ -381,7 +380,6 @@ DEPENDENCIES
jsbundling-rails
kaminari
launchy
normalize-rails
oath
pg
pry-byebug
Expand Down
1 change: 0 additions & 1 deletion app/assets/stylesheets/admin/admin.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
@use "sass:math";

@import "../reset";
@import "normalize.css";
@import "variables";

@import "base";
Expand Down
6 changes: 2 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
"@rails/activestorage": "^6.0.3-3",
"@rails/ujs": "^6.0.3-3",
"esbuild": "^0.14.28",
"esbuild-sass-plugin": "^2.2.5",
"normalize.css": "^8.0.1",
"sass": "^1.54.3",
"webpack-jquery-ui": "^2.0.1"
"jquery": "^3.6.1",
"sass": "^1.54.3"
},
"devDependencies": {},
"scripts": {
Expand Down

0 comments on commit 651f696

Please sign in to comment.