-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symbols= parameter doesn't work with compressed revisions ($wgCompressRevisions = true) #7
Comments
Not reproduced locally. Might be caused by one of the pages in the wiki having incorrect UTF-8 on it. The error mentioned on https://phabricator.miraheze.org/T9688 is happening in MediaWiki parser (not in the JsCalendar code):
It's theoretically possible that the page had incorrect UTF-8 on it (JsCalendar passes contents of the page to MediaWiki parser), JsCalendar doesn't do any transformations to the "contents of the page" string before passing it to Parser. It's not truncated, not wrapped, not encoded, etc. JsCalendar takes the page text directly from the database and gives it to Parser. |
See https://phabricator.wikimedia.org/T321234 |
FWIW, to reiterate what i said on the other bug, I do not believe that this issue is the same as https://phabricator.wikimedia.org/T321234. https://phabricator.wikimedia.org/T321234 is about old non-utf8 valid data that for some reason was not normalized properly. Any page that this is happening on that is less than 15 years old, probably has a different cause (May or may not be this extensions fault, I'm not familiar with this extensions code. Could be some other issue at miraheze) |
It may quite possibly be the fault of code at https://github.com/edwardspec/mediawiki-extension-JsCalendar/blob/master/includes/FindEventPagesQuery.php#L188 - this is not processing the old_flags field properly, which could result in the exception described depending on the wikis config (Processing old_flags properly is really hard, I would generally recommend using MW core's various classes to get page text instead if at all possible) |
Thank you. Turns out, Miraheze had
Will investigate. This seems to be handled in |
Should be working now. |
This issue makes JsCalendar unusable/broken with the "symbols" parameter.
I mistakenly reported this bug on the Mediawiki Phabricator. I explained it in depth there, so to not repeat the same thing here's the link to the report:
https://phabricator.wikimedia.org/T331228
The text was updated successfully, but these errors were encountered: