Add iOS 8 to deployment target to allow framework use on iOS without Cocoapods #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there. Thank you for taking the time to open this PR. I recognise that it has now been a few years since this was opened and that Xcode no longer supports the iOS 8 SDK. If support for iOS 8 is something that you still need, I would recommend maintaining your own fork of this project. Any questions, please let me know. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great framework you have here, I like your approach.
Adding it with Carthage produces an error due to the missing iOS 8 deployment target in the project settings. Would you consider this change? I can run further tests if required.
Thank you.