Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows attachments as tuples #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rjsheperd
Copy link

In trying to use django-mail-templated along with some file attachments. Unfortunately the attachment type that is produced using EmailMessage#attach_file is a tuple, not an attachment instance.

I'm not sure if we can get django-mail-templated to conform to the attachment type that django-naomi is anticipating.

Doing this since I'm not sure if we can get django-mail-templated
to conform to the attachment type that django-naomi is anticipating
@SalahAdDin
Copy link

👍

@rjsheperd rjsheperd closed this Jun 19, 2017
@SalahAdDin
Copy link

@rjsheperd why did you close it?

@rjsheperd rjsheperd reopened this Jun 20, 2017
@rjsheperd
Copy link
Author

Sorry, I didn't mean to! I don't have write access, so we'll need to have @edwinlunando or another maintainer to merge it :)

@edwinlunando
Copy link
Owner

@rjsheperd I'm really sorry for letting this one for a long time! Yes, this is a good addition. Thank you. Will update and release a new version.

@SalahAdDin
Copy link

@edwinlunando @aericson When will you merge this PR?

@SalahAdDin
Copy link

SalahAdDin commented Mar 21, 2018

@aericson Man? Please

@aericson
Copy link

I'm not the mantainer, I can't merge this.

@SalahAdDin
Copy link

@edwinlunando, please.

@omkarvijay5
Copy link

omkarvijay5 commented Sep 7, 2018

@edwinlunando i am getting error while sending email with an attachment:

tuple object has no attribute name. The attachments are fetching as tuples rather than an object. is there a fix for it?

@SalahAdDin
Copy link

we are waiting still for that.

@junejie
Copy link

junejie commented Nov 13, 2020

any updates?

@Leden
Copy link

Leden commented Oct 11, 2022

Any updates?

@SalahAdDin
Copy link

Any updates?

Is this project even maintained yet?

@yujinyuz
Copy link

yujinyuz commented Apr 6, 2024

Hi, in case anyone is still interesed, I created a new project based on this repository and applied some of the open PRs as well

https://github.com/yujinyuz/django-unravel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants