New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows attachments as tuples #3
base: master
Are you sure you want to change the base?
Allows attachments as tuples #3
Conversation
Doing this since I'm not sure if we can get django-mail-templated to conform to the attachment type that django-naomi is anticipating
👍 |
@rjsheperd why did you close it? |
Sorry, I didn't mean to! I don't have write access, so we'll need to have @edwinlunando or another maintainer to merge it :) |
@rjsheperd I'm really sorry for letting this one for a long time! Yes, this is a good addition. Thank you. Will update and release a new version. |
@edwinlunando @aericson When will you merge this PR? |
@aericson Man? Please |
I'm not the mantainer, I can't merge this. |
@edwinlunando, please. |
@edwinlunando i am getting error while sending email with an attachment: tuple object has no attribute name. The attachments are fetching as tuples rather than an object. is there a fix for it? |
we are waiting still for that. |
any updates? |
Any updates? |
Is this project even maintained yet? |
Hi, in case anyone is still interesed, I created a new project based on this repository and applied some of the open PRs as well |
In trying to use
django-mail-templated
along with some file attachments. Unfortunately the attachment type that is produced usingEmailMessage#attach_file
is a tuple, not an attachment instance.I'm not sure if we can get
django-mail-templated
to conform to the attachment type thatdjango-naomi
is anticipating.