fix boolean logic

edwmurph · Jan 26, 2021 · d9a7fdc · d9a7fdc
1 parent b230660
commit d9a7fdc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -93,7 +93,7 @@ const upgradeDeps = async({ breaking }) => {
         dependencies.map(([name, version]) => {
           const prevVersion = packageJSON.dependencies[name];
           const majorBump = prevVersion.split('.')[0] !== version.split('.')[0];
-          return [name, breaking && majorBump ? version : prevVersion];
+          return [name, !majorBump || breaking ? version : prevVersion];
         }),
       );
     }
@@ -103,12 +103,12 @@ const upgradeDeps = async({ breaking }) => {
         devDependencies.map(([name, version]) => {
           const prevVersion = packageJSON.devDependencies[name];
           const majorBump = prevVersion.split('.')[0] !== version.split('.')[0];
-          return [name, breaking && majorBump ? version : prevVersion];
+          return [name, !majorBump || breaking ? version : prevVersion];
         }),
       );
     }
 
-    await writeFileAsync( 'package.json', JSON.stringify( updated, null, 2 ) );
+    await writeFileAsync( 'package.json', JSON.stringify( updated, null, 2 ).trim() );
 
     await execAsync( `rm -rf ${ storage }` );
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "upgrade-deps",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "CLI for automating updating package.json dependencies",
   "main": "index.js",
   "scripts": {