-
Notifications
You must be signed in to change notification settings - Fork 16
MCKIN-9091: Aggregation integration tests #1289
Conversation
d39b292
to
91a8bf0
Compare
@jcdyer Are you checking for BlockCompletions submitted in various configurations? I can't find it in the code, but maybe I am overlooking something. |
7016428
to
09379d9
Compare
@Metfriet I added some tests to verify the behavior of different configurations. |
@jcdyer ok it looks good now. I will approve it when circleci is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally approved just now, but the tests are actually failing, also I don't have write access so you'll need to find someone else to also review this. @jcdyer
Oh weird. Those are passing for me locally. |
That took longer to diagnose than it should. The tests are passing on lms, but not cms. They need to be flagged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍 @jcdyer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 approving it based on @Metfriet's review
@jcdyer can you please provide MCKIN lira ticket number against this work? I need this info to prepare release |
This did not have a MCKIN ticket, so I've created one at https://edx-wiki.atlassian.net/browse/MCKIN-9091. The only modifications here are adding tests (and fixing one tiny configuration error in LibraryContent module that was caught by the tests). |
Create aggregation integration tests.
These are moved over from edx/edx-platform#17703, because it was too hard to keep them in sync with the changing platform, and there was no good end plan for merging the code. Here, it can be merged cleanly, and run with regular platform tests.
JIRA tickets: BB-157, BB-163 , MCKIN-9091
Discussions: See references JIRA tickets, and mainline edx-platform PR.
Dependencies: None
Screenshots:
Sandbox URL: TBD - sandbox is being provisioned.
Merge deadline: None
Testing instructions:
Author notes and concerns:
Reviewers
Settings
N/A