This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
add subscribe command for notifications #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| subscribe [user] to [jobid]: request to be notified when builds complete | ||
| """ | ||
| if "me" == user: |
There was a problem hiding this comment.
I would swap me and user so that the statement is more readable.
| if user == "me": | ||
| user = message.sender.nick | ||
| else: | ||
| user = user.replace("@", "") |
There was a problem hiding this comment.
Why remove the @ when we just add it back on the next line?
There was a problem hiding this comment.
Your regex will remove all the @ symbols at the beginning of the username.
fredsmith
force-pushed
the
derf/subscribe_command
branch
from
59bb094
to
2dc449d
Compare
fredsmith
pushed a commit
that referenced
this pull request
May 29, 2015
add subscribe command for notifications
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.