Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate edx specific color variables #19

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

abutterworth
Copy link
Contributor

These variables were added to this theme in error. Consuming applications should only use variable names that also exist in the Paragon core ($primary-300, $light, etc).

After we confirm that no consuming applications use these edx-specific variables, we'll delete them.

@abutterworth abutterworth requested a review from a team December 1, 2020 16:58
Copy link
Contributor

@AlasdairSwan AlasdairSwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlasdairSwan
Copy link
Contributor

Is there a timeline for when the deprecated variables will be removed?

@abutterworth
Copy link
Contributor Author

@AlasdairSwan I'll remove these variables after December 15th and before January 1st.

@abutterworth abutterworth merged commit fea9f68 into master Dec 1, 2020
@abutterworth abutterworth deleted the abutterworth/deprecate-edx-variables branch December 1, 2020 17:39
@edx-semantic-release
Copy link
Collaborator

🎉 This PR is included in version 1.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants