[BD-46] fix: a11y update bubble and badge #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
monteri
commented
Aug 4, 2022
monteri
commented
- Change Badge color according to A11y Update: Change Badge component "Info" variant text color to black openedx/paragon#1428
- Change Bubble color according to A11y Update: Bubble Component openedx/paragon#1500
|
Thanks for the pull request, @monteri! When this pull request is ready, tag your edX technical lead. |
monteri
changed the title
| // Bubble | ||
| .pgn__bubble { | ||
| &.pgn__bubble-warning { | ||
| color: $gray-900; |
There was a problem hiding this comment.
Good catch that the text color on the warning variant is also not passing valid a11y contrast ratio. Though, it's also not a valid contrast ratio in the core Paragon theme (Open edX) either. If we want it to have a valid contrast ratio for both themes, would it make sense to add this text color change to the core theme?
adamstankiewicz
approved these changes
Aug 12, 2022
|
@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
🎉 This PR is included in version 2.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.