Skip to content

Commit

Permalink
Merge pull request openedx-unsupported#140 from edx/dsjen/metadata-utc
Browse files Browse the repository at this point in the history
Use date instead of datetime in ModuleEngagementMetricRanges.
  • Loading branch information
dsjen committed Sep 21, 2016
2 parents 0bc468a + 8cdacb7 commit cfd9c41
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -270,5 +270,5 @@ def handle(self, *args, **options):
self.generate_video_data(course_id, video_id, video_module_id)
self.generate_video_timeline_data(video_id)
self.generate_learner_engagement_data(course_id, username, start_date, end_date)
self.generate_learner_engagement_range_data(course_id, start_date, end_date)
self.generate_learner_engagement_range_data(course_id, start_date.date(), end_date.date())
self.generate_tags_distribution_data(course_id)
4 changes: 2 additions & 2 deletions analytics_data_api/v0/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -495,9 +495,9 @@ class ModuleEngagementMetricRanges(models.Model):
"""

course_id = models.CharField(db_index=True, max_length=255)
start_date = models.DateTimeField()
start_date = models.DateField()
# This is a left-closed interval. No data from the end_date is included in the analysis.
end_date = models.DateTimeField()
end_date = models.DateField()
metric = models.CharField(max_length=50)
range_type = models.CharField(max_length=50)
# Also a left-closed interval, so any metric whose value is equal to the high_value
Expand Down
4 changes: 2 additions & 2 deletions analytics_data_api/v0/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,8 @@ def get_videos_viewed(self, obj):

# pylint: disable=abstract-method
class DateRangeSerializer(serializers.Serializer):
start = serializers.DateTimeField(source='start_date', format=settings.DATE_FORMAT)
end = serializers.DateTimeField(source='end_date', format=settings.DATE_FORMAT)
start = serializers.DateField(source='start_date', format=settings.DATE_FORMAT)
end = serializers.DateField(source='end_date', format=settings.DATE_FORMAT)


# pylint: disable=abstract-method
Expand Down
9 changes: 4 additions & 5 deletions analytics_data_api/v0/tests/views/test_learners.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from django_dynamic_fixture import G
from elasticsearch import Elasticsearch
from mock import patch, Mock
import pytz
from rest_framework import status

from django.conf import settings
Expand Down Expand Up @@ -784,8 +783,8 @@ def test_no_engagement_ranges(self):

def test_one_engagement_range(self):
metric_type = 'problems_completed'
start_date = datetime.datetime(2015, 7, 1, tzinfo=pytz.utc)
end_date = datetime.datetime(2015, 7, 21, tzinfo=pytz.utc)
start_date = datetime.date(2015, 7, 1)
end_date = datetime.date(2015, 7, 21)
G(ModuleEngagementMetricRanges, course_id=self.course_id, start_date=start_date, end_date=end_date,
metric=metric_type, range_type='normal', low_value=90, high_value=6120)
expected_ranges = self.empty_engagement_ranges
Expand All @@ -807,8 +806,8 @@ def test_one_engagement_range(self):

def _get_full_engagement_ranges(self):
""" Populates a full set of engagement ranges and returns the expected engagement ranges. """
start_date = datetime.datetime(2015, 7, 1, tzinfo=pytz.utc)
end_date = datetime.datetime(2015, 7, 21, tzinfo=pytz.utc)
start_date = datetime.date(2015, 7, 1)
end_date = datetime.date(2015, 7, 21)

expected = {
'engagement_ranges': {
Expand Down

0 comments on commit cfd9c41

Please sign in to comment.