Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-14] Add StudioHeader header variant #102

Closed

Conversation

gabor-boros
Copy link

@gabor-boros gabor-boros commented Oct 9, 2020

This PR adds a new shared header component, which is based on the already existing Header and can be used across Studio related pages and frontend apps like the library authoring app.

Also, from this point, other header variants could be created easily. Besides that, those components/pages using this new StudioHeader variant can add children components if required.

JIRA tickets: TNL-7403 / TNL-7503

Discussions: Link to any public dicussions about this PR or the design/architecture. Otherwise omit this.

Dependencies:

Screenshots:

Screenshot 2020-10-12 at 11 10 54

The new header in use:

Screenshot 2020-10-09 at 17 17 18

Screenshot 2020-10-09 at 17 20 04

Sandbox URL: N/A

Merge deadline: None

Testing instructions:

  1. TBD

Author notes and concerns:

  1. TBD

Reviewers

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 9, 2020

Thanks for the pull request, @gabor-boros! I've created BLENDED-626 to keep track of it in Jira. More details are on the BD-14 project page.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@gabor-boros gabor-boros marked this pull request as draft October 9, 2020 16:42
@natabene
Copy link

@marcotuts Is this a Blended ticket?

@gabor-boros gabor-boros changed the title [SE-3447] Add StudioHeader header variant [BD-14] Add StudioHeader header variant Oct 12, 2020
@gabor-boros
Copy link
Author

@natabene Yes it is, BD-14. Just updated the title.

@kdmccormick
Copy link

Thanks for your work so far on this. We're pausing development and code review on BD-14 for now to allow more planning and design to be done before work is resumed on Milestone 3. Until then, edX most likely won't be able to review this PR.

@marcotuts
Copy link

@davidjoy - can you clarify if we've taken a different approach here? this has been sitting for a while but the team working on BD-14 was looking to pick this up soon

@davidjoy
Copy link
Contributor

In general, yes, this is still the approach.

The point of adding the StudioHeader in this repository is to provide an edx.org specific override to the generic StudioHeader added to frontend-component-header. If that header doesn't exist, it'll need to be added and used in the MFE first before adding anything here will be meaningful.

The point of adding the header to frontend-component-header is so that Open edX operators can override it with their own custom version - including us.

Since this PR was created, a team added the Learning MFE's header to this repo and to frontend-component-header. I would suggest modeling the directory structure/exports of this PR after that header for consistency. That might require a little refactoring in this PR; I'm not quite sure how different they are. But it shouldn't be that bad regardless.

@gabor-boros
Copy link
Author

@arbrandes Since openedx/frontend-app-library-authoring#18 is closed (openedx/frontend-app-library-authoring#36 (comment)), should we close this too or is this something to keep?

@natabene natabene assigned jristau1984 and unassigned jristau1984 May 14, 2022
@arbrandes
Copy link

Like openedx/frontend-platform#116, this can be closed.

@natabene natabene closed this Jul 27, 2022
@openedx-webhooks
Copy link

@gabor-boros Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@gabor-boros gabor-boros deleted the gabor/add-studio-header-variant branch July 27, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants