Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification tray height issues #479

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

sundasnoreen12
Copy link
Collaborator

INF-1052

Description

Fixed following issues.

  1. The notifications tray looks to be overlapping the NAV
  2. When I scroll down the page I see a gap at the top, showing other LMS content:
  3. There’s also a gap on the right, showing LMS content:

Screenshots
Screenshot 2023-10-04 at 2 58 57 PM

Screenshot 2023-10-04 at 2 59 06 PM

src/Notifications/index.jsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #479 (f0c3681) into master (903802d) will increase coverage by 0.69%.
Report is 8 commits behind head on master.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
+ Coverage   76.47%   77.17%   +0.69%     
==========================================
  Files          48       48              
  Lines         744      736       -8     
  Branches      134      133       -1     
==========================================
- Hits          569      568       -1     
+ Misses        172      165       -7     
  Partials        3        3              
Files Coverage Δ
src/Notifications/index.jsx 82.60% <83.33%> (+10.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sundasnoreen12 sundasnoreen12 merged commit 17eee9d into master Oct 10, 2023
6 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1052 branch October 10, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants