feat: usama test script

edx · Aug 31, 2023 · 2ddc6ac · 2ddc6ac
1 parent 38f0c5a
commit 2ddc6ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/dataeng/jobs/analytics/UsamaTest.groovy b/dataeng/jobs/analytics/UsamaTest.groovy
@@ -18,7 +18,6 @@ class UsamaTest {
                 stringParam('ANALYTICS_TOOLS_BRANCH', allVars.get('ANALYTICS_TOOLS_BRANCH'), 'Branch of analytics tools repo to use.')
                 stringParam('NOTIFY', allVars.get('NOTIFY','$PAGER_NOTIFY'), 'Space separated list of emails to send notifications to.')
                 stringParam('PYTHON_VENV_VERSION', 'python3.7', 'Python virtual environment version to used.')
-                stringParam('ENVIRONMENT', '', 'edx environment which contains Amplitude credentials.')
                 stringParam('AMPLITUDE_DATA_SOURCE_TABLE', '', 'Table name that has data which needs to be updated on Amplitude. It should have format like database.schema.table.')
                 stringParam('COLUMNS_TO_UPDATE', '', 'Columns that you want to update. Separate multiple columns with commas.')
                 stringParam('RESPONSE_TABLE', '', 'Output table which will store the updated data along with response from API endpoint.')

diff --git a/dataeng/resources/amplitude-properties-backfill.sh b/dataeng/resources/amplitude-properties-backfill.sh
@@ -21,10 +21,10 @@ export VAULT_TOKEN=$(vault write -field=token auth/approle/login \
       secret_id=${ANALYTICS_VAULT_SECRET_ID}
   )
 
-AMPLITUDE_API_KEY=$(
+API_KEY=$(
   vault kv get \
     -version=${AMPLITUDE_VAULT_KV_VERSION} \
-    -field=api_key \
+    -field=API_KEY \
     ${AMPLITUDE_VAULT_KV_PATH} \
 )
 
@@ -37,4 +37,4 @@ python amplitude_user_properties_update.py \
     --columns_to_update $COLUMNS_TO_UPDATE \
     --response_table $RESPONSE_TABLE \
     --amplitude_operation_name $AMPLITUDE_OPERATION_NAME \
-    --amplitude_api_key $AMPLITUDE_API_KEY
+    --amplitude_api_key $API_KEY