Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove secure scm #1769

Merged
merged 1 commit into from
May 29, 2024
Merged

chore: remove secure scm #1769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions dataeng/jobs/analytics/SnowflakeCollectMetrics.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ package analytics

import static org.edx.jenkins.dsl.AnalyticsConstants.common_log_rotator
import static org.edx.jenkins.dsl.AnalyticsConstants.common_publishers
import static org.edx.jenkins.dsl.AnalyticsConstants.secure_scm
import static org.edx.jenkins.dsl.AnalyticsConstants.secure_scm_parameters


class SnowflakeCollectMetrics {
Expand All @@ -23,7 +21,6 @@ class SnowflakeCollectMetrics {
dslFactory.job(jobConfig['NAME']){

logRotator common_log_rotator(allVars)
parameters secure_scm_parameters(allVars)
parameters {
stringParam('ANALYTICS_TOOLS_URL', allVars.get('ANALYTICS_TOOLS_URL'), 'URL for the analytics tools repo.')
stringParam('ANALYTICS_TOOLS_BRANCH', allVars.get('ANALYTICS_TOOLS_BRANCH'), , 'Branch of analytics tools repo to use.')
Expand All @@ -36,7 +33,7 @@ class SnowflakeCollectMetrics {
env('SNOWFLAKE_WAREHOUSE', 'LOADING')
env('METRIC_NAME', jobConfig['NAME'])
}
multiscm secure_scm(allVars) << {
multiscm {
git {
remote {
url('$ANALYTICS_TOOLS_URL')
Expand Down
5 changes: 1 addition & 4 deletions dataeng/jobs/analytics/SnowflakePublicGrantsCleaner.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,13 @@ import static org.edx.jenkins.dsl.AnalyticsConstants.common_log_rotator
import static org.edx.jenkins.dsl.AnalyticsConstants.common_wrappers
import static org.edx.jenkins.dsl.AnalyticsConstants.common_publishers
import static org.edx.jenkins.dsl.AnalyticsConstants.common_triggers
import static org.edx.jenkins.dsl.AnalyticsConstants.secure_scm_parameters
import static org.edx.jenkins.dsl.AnalyticsConstants.secure_scm



class SnowflakePublicGrantsCleaner {
public static def job = { dslFactory, allVars ->
dslFactory.job("snowflake-public-grants-cleaner") {
logRotator common_log_rotator(allVars)
parameters secure_scm_parameters(allVars)
parameters {
stringParam('ANALYTICS_TOOLS_URL', allVars.get('ANALYTICS_TOOLS_URL'), 'URL for the analytics tools repo.')
stringParam('ANALYTICS_TOOLS_BRANCH', allVars.get('ANALYTICS_TOOLS_BRANCH'), 'Branch of analtyics tools repo to use.')
Expand All @@ -28,7 +25,7 @@ class SnowflakePublicGrantsCleaner {
env('USER', allVars.get('USER'))
env('ACCOUNT', allVars.get('ACCOUNT'))
}
multiscm secure_scm(allVars) << {
multiscm {
git {
remote {
url('$ANALYTICS_TOOLS_URL')
Expand Down
Loading