Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor asInput #229

Closed
thallada opened this issue Apr 26, 2018 · 1 comment
Closed

Refactor asInput #229

thallada opened this issue Apr 26, 2018 · 1 comment
Assignees

Comments

@thallada
Copy link
Contributor

Over time, asInput has grown a lot to support many features. It could be split up more to compose itself out of smaller sub-components. Part of this work was done by extracting the validation message out into a ValidationMessage component. We could also make Label and InputDescription components, for example. Exporting these components to Paragon users would also allow them to compose their own custom input components if asInput does give them the flexibility that they need.

See reactstrap for examples of how granular the sub-components could get (basically one component per HTML div). Internally, Paragon could build asInput out of these more granular components so that users of Paragon could use asInput to create basic inputs quickly, but also use the granular sub-components if they need more customization than asInput provides.

There are some special-cases for checkboxes, but not for radio buttons. That part could be a bit more abstracted.

@abutterworth
Copy link
Contributor

asInput has been replaced by React Bootstrap Form components #550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants