fix(asinput): Accessibility fixes for asInput #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
thallada
force-pushed
the
thallada/input-error-message-aria-live
branch
from
168547d
to
7db03cc
Compare
thallada
force-pushed
the
thallada/input-error-message-aria-live
branch
from
7db03cc
to
ea64170
Compare
arizzitano
pushed a commit
that referenced
this pull request
Dec 13, 2017
docs(readme): add semantic-release documentation docs(readme): add semantic-release notes to documentation docs(readme): add cli gif link docs(readme): fix some formatting docs(readme): add more background information fix(asinput): Accessibility fixes for asInput (#97) * fix(asinput): Add screen-reader text for danger icon * fix(asinput): Load form-control-feedback on page load w/ aria-live fix(readme): Document how to run jest tests in Chrome DevTools (#96) Also adds an npm run test-debug script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: @edx/educator-dahlia
This addresses EDUCATOR-1952.
form-control-feedbackdiv referenced byaria-describedbymust exist on the page when it is initially loaded for screen-readers. Bootstrap's css will hide it unless there is a validation error.aria-live="polite"so that the error message is read out to the screen-reader user after validation happens.sr-onlydiv to the error span to describe the font awesome error icon. Users of paragon will have to pass in their own translated stringdangerIconDescriptionfor the description.TODO